Jeff Law <l...@redhat.com> writes:
> On 9/3/18 8:48 AM, Vinay Kumar wrote:
>> Hi Joseph,
>>
>>>> The documentation is of a new option, not of -Wreturn-type
>> Done
>>
>>>> you should list the option as -Wno-prio-ctor-dtor when documenting
>> Done
>>
>>>> You're not meant to have the literal text ", no ()" in the manual
>> Sorry for the confusion. Modified it accordingly
>>
>>>> I don't see why a g++.dg one is needed as well
>> Removed.
>>
>> Thanks for reviewing the patch and your suggestions.
>> Please find attached the modified patch as per your review comments.
>> Please review the patch and let me know if its okay?
>>
>> Thanks,
>> Vinay
>>
>>
>> Wprio-ctor-dtor.patch
> [ ... ]
> THanks. I've installed this on the trunk.
the new test FAILs on Solaris 10 and Darwin:
+FAIL: c-c++-common/Wprio-ctor-dtor.c -std=gnu++11 (test for excess errors)
+FAIL: c-c++-common/Wprio-ctor-dtor.c -std=gnu++14 (test for excess errors)
+FAIL: c-c++-common/Wprio-ctor-dtor.c -std=gnu++98 (test for excess errors)
+FAIL: c-c++-common/Wprio-ctor-dtor.c -Wc++-compat (test for excess errors)
Excess errors:
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c:4:1:
error: constructor priorities are not supported
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c:5:1:
error: constructor priorities are not supported
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c:6:1:
error: constructor priorities are not supported
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c:7:1:
error: destructor priorities are not supported
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c:8:1:
error: destructor priorities are not supported
/vol/gcc/src/hg/trunk/local/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c:9:1:
error: destructor priorities are not supported
Fixed as follows. Tested on i386-pc-solaris2.10 and i386-pc-solaris2.11
(which supports constructor priorities), installed on mainline.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
2018-10-08 Rainer Orth <r...@cebitec.uni-bielefeld.de>
* c-c++-common/Wprio-ctor-dtor.c: Require init_priority support.
# HG changeset patch
# Parent cc66d1590b066afb38169d9313af97f741401e80
Require constructor priority support in c-c++-common/Wprio-ctor-dtor.c
diff --git a/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c b/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c
--- a/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c
+++ b/gcc/testsuite/c-c++-common/Wprio-ctor-dtor.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target init_priority } */
/* { dg-options "-Wno-prio-ctor-dtor" } */
void construct1 () __attribute__ ((constructor (10)));
