On Fri, Oct 05, 2018 at 10:54:18AM -0500, Paul Clarke wrote:
> On 10/05/2018 04:20 AM, Segher Boessenkool wrote:
> >> @@ -0,0 +1,49 @@
> >> +/* { dg-do compile } */
> >> +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
> >> +/* { dg-options "-O3 -mdirect-move" } */
> >
> > -mdirect-move is deprecated and doesn't do anything. You want -mcpu=power8
> > if you want to enable power8 instructions. (Or -mpower8-vector also works,
> > for the time being anyway, but it is not preferred).
>
> All of the gcc/testsuite/gcc.target/powerpc/sse2*.c use "-mpower8-vector".
> Shall I use that, or "-mcpu=power8"?
Ah right. No, just keep it all the same, it is easiest.
> > Have you tested this with -mcpu= an older cpu? Did that work? (It won't
> > _do_ much of course, but are there extra unexpected errors, etc.)
>
> I just did, at your urging. Seems OK.
Nice, thanks.
> >> +/* { dg-require-effective-target lp64 } */
> >
> > Do these tests actually need this? For what, then?
>
> All of the gcc/testsuite/gcc.target/powerpc/sse2*.c use it. I will profess
> my ignorance. Should it be used?
It means this test will only run on 64-bit compiles. As long as we allow
the header to be used on 32-bit compiles (or on BE, etc.), preventing it
from being tested there is not so great.
But if all the existing things do this, it's fine to follow suit.
Segher
