On 24/09/18 10:19, Eric Botcazou wrote: >> Ah! But that still doesn't explain why you want to skip these passes >> when building thunks. > > They simply don't work because there is no CFG for thunks; I can add a blurb > about that.
Yes, this needs a comment as it's far from obvious when looking at the code. > >> So is the barrier correct, or isn't it? There's really no two ways >> about this. I don't like arbitrary changes that are justified solely on >> 'that's what another port does'. > > The barrier is required by the arm_reorg pass, but it is optional when the > pass is not run. I think that we can consider that it is also correct. > Ah, because you're now calling arm_reorg directly and it needs the barrier to drop the minipool in the right place. So OK with the additional comment. R.
