On Wed, Nov 02, 2011 at 02:55:54PM +0100, Rainer Orth wrote: > Jakub Jelinek <ja...@redhat.com> writes: > > > Anyway, in the other gcc.dg/strlenopt-* testcases for USE_GNU I was using > > the convention that the name ended with g (i.e. strlenopt-22g.c) and > > the test would start with: > > /* This test needs runtime that provides stpcpy function. */ > > /* { dg-do run { target *-*-linux* } } */ > > instead of just > > /* { dg-do run } */ > > This isn't right either: e.g. Solaris 11 does have stpcpy, as do systems > with a non-Linux kernel, but using *glibc. If there are more than one or > two instances of this, this needs an effective-target keyword, along the > lines of target-supports.exp (check_mkfifo_available).
Feel free to change it, it isn't too important to me, all it would buy us is additional testing of generic optimizations on a tiny bit more targets. Some strlenopt-*f.c tests also need __*_chk functions, either just those, or those and stpcpy. Jakub