On 09/04/2018 09:40 PM, Segher Boessenkool wrote:
> Hi!
>
> On Tue, Sep 04, 2018 at 04:02:23PM +0200, Martin Liška wrote:
>> Option mdirect-move should be Deprecated, that means option value is ignored
>> and user can't influence rs6000_isa_flags.
>>
>> Patch can bootstrap on ppc64le-redhat-linux (gcc110 and gcc112) and survives
>> regression tests.
>>
>> Ready to be installed?
>
> So the mask is still defined then, and mask for that variable? Sounds fine
> then, thanks.
Yes, Deprecated is basically Ignore+Warn(...).
>
> The other issue is still there: options.texi says:
> @item Ignore
> This option is ignored apart from printing any warning specified using
> @code{Warn}.
>
> So Warn is explicitly allowed with Ignore, not forbidden. If you want to
> change that, you'll have to change the documentation as well ;-)
Which means yes, the documentation is not correct. I'm suggesting that:
diff --git a/gcc/doc/options.texi b/gcc/doc/options.texi
index f887d16f88f..dd201c3b7bc 100644
--- a/gcc/doc/options.texi
+++ b/gcc/doc/options.texi
@@ -431,9 +431,10 @@ negated. @code{NegativeAlias} may not be used with the
forms of
@code{Alias} taking more than one argument.
@item Ignore
-This option is ignored apart from printing any warning specified using
-@code{Warn}. The option will not be seen by specs and no @samp{OPT_}
-enumeration value is defined for it.
+This option is ignored and the option will not be seen by specs
+and no @samp{OPT_} enumeration value is defined for it. The option
+cannot be combined with @code{Warn} and in such case @code{Deprecated}
+should be used.
@item SeparateAlias
For an option marked with @code{Joined}, @code{Separate} and
Feel free to make language correction. I'm going to install the current fix
for the PR and documentation can be updated independently.
Martin
>
> I'll test it later, might be tomorrow. Thanks,
>
>
> Segher
>
