Hi Kelvin, On Tue, Aug 07, 2018 at 05:42:48PM -0500, Kelvin Nilsen wrote: > > My "consistency" check was against the implementation. > > On 8/2/18 11:38 AM, Segher Boessenkool wrote: > > On Wed, Aug 01, 2018 at 02:55:22PM -0500, Kelvin Nilsen wrote: > >> Several errors were discovered in the descriptions of the > >> __builtin_bcdadd, __builtin_bcdadd_lt, __builtin_bcdadd_eq, > >> __builtin_bcdadd_gt, __builtin_bcdadd_ov, __builtin_bcdsub, > >> __builtin_bcdsub_lt, __builtin_bcdsub_eq, __builtin_bcdsub_gt, and > >> __builtin_bcdsub_ov functions. This patch corrects these documentation > >> errors. > > > > What did you check this against? The ABI doc, or what is currently > > implemented? Neither is very clear to me :-/
The ABI calls for "const int" here. Ah, the code only check for 0 or 1 I think? Please change the documentation to const int then. Or, alternatively, what do I miss? Okay for trunk with const int. Thanks! Segher
