On 06/08/18 15:00, Christophe Lyon wrote: > On Fri, 27 Jul 2018 at 11:38, Richard Earnshaw <richard.earns...@arm.com> > wrote: >> >> >> This patch defines a speculation barrier for AArch32. >> >> * config/arm/unspecs.md (unspecv): Add VUNSPEC_SPECULATION_BARRIER. >> * config/arm/arm.md (speculation_barrier): New expand. >> (speculation_barrier_insn): New pattern. >> --- > > Hi Richard, > > This patch causes compilation errors for c-c++-common/spec-barrier-2.c > when compiled for old architectures (eg -march=armv5t): > /ccrf2LoR.s:49: Error: selected processor does not support `isb' in ARM mode > /ccrf2LoR.s:50: Error: selected processor does not support `dsb sy' in ARM > mode > > Does this belong to the kind of failures you still expect from this > patch series? >
Nope :-( I'll look into it. We may need to just disable these patterns for architectures that old. Thumb1 code on pre-v6t2 similarly can't be protected. Thanks for reporting. R.
