On Thu, Aug 2, 2018 at 1:44 AM, Pierre-Marie de Rodat <dero...@adacore.com> wrote: > On 07/06/2018 01:45 AM, Jim Wilson wrote: >> >> These are some patches I needed to complete my cross build of a native >> riscv linux Ada compiler. Some paths were different on the build machine >> and host machine. I needed to pass options into gnatmake to work around >> this, >> and that required fixing some makefile rules to use $(GNATMAKE) instead of >> calling gnatmake directly. > > > At AdaCore, we realized that this patch broke our canadian builds: in the > cases your patch involved, the intent is to call the build toolchain, not > the host one (to which GNATMAKE expands to). > > Given that you described this change as a workaround for cross-machine path > issues, I was wondering: do you still need this? If not, we should probably > revert it right now, otherwise we should investigate why you needed it in > the first place. What do you think?
I only needed it for the first canadian cross build. If it is causing problems for you it can be dropped. If I need it again, it is easy enough to write again. I ran into a problem where the search paths were wrong when running the canadian cross built compiler for the native build, and I had to add something like -cargs -L$installdir/lib to gnatmake to make it work, but it is possible I did something wrong. These canadian cross builds aren't something I do often, so I might have made a mistake. Also, RISC-V is a new target, so there are lots of things that are just a little broken and have to be worked around. This might have been related to one of those problems. Jim
