> I missed your approval and didn't get to committing the patch > until today. While retesting it on top of fresh trunk I noticed > a few test failures due to other recent strlen changes. I made > adjustments to the patch to avoid most of them and opened bug > 86688 for one that I think needs a separate code change and > xfailed the test cases until the bug gets resolved.
But it has introduced a couple of regressions in the ACATS testsuite: FAIL: c52103c FAIL: cde0001 === acats Summary === # of expected passes 2318 # of unexpected failures 2 Native configuration is x86_64-suse-linux-gnu +===========================GNAT BUG DETECTED==============================+ | 9.0.0 20180727 (experimental) [trunk revision 263028] (x86_64-suse-linux) GCC error:| | in handle_char_store, at tree-ssa-strlen.c:3332 | | Error detected around c52103c.adb:43:1 | -- Eric Botcazou