On Sat, Jul 07, 2018 at 11:07:28AM +0000, Tamar Christina wrote:
> > On Fri, Jul 06, 2018 at 11:46:43AM +0100, Tamar Christina wrote:
> > > This fixes an ABI warning generated on i686-pc-linux-gnu when using
> > > `vector_size` with no sse enabled explicitly.
> > >
> > > Regtested single test on x86_64-pc-linux-gnu with -m32 and no issues.
> > >
> > > Committed under the GCC obvious rule.
> >
> > That is insufficient, I get the FAIL on i686-linux.
> > You don't really need dg-require-effective-target sse, it is a dg-do compile
> > time only test and on i?86/x86_64 failures with old assemblers would show up
> > only when assembling.
> > But -msse really should be used on all i?86-*-* and x86_64-*-*.
>
> Ah I wasn't are of that, I initially didn't add it to x86-64 since the
> test wasn't generating the ABI warning there. But this is good to know
> for the future.
The thing is that i?86-*-* and x86_64-*-* can be both multilib, and only the
-m64 and -mx32 multilibs default to -msse2, -m32 does not.
In gcc.target/ia32 one uses typically ia32 effective target for the -m32
i?86/x86_64 multilib, but in this case it doesn't hurt to add -msse to all.
Jakub
