On June 28, 2018 12:28:15 PM GMT+02:00, Eric Botcazou <ebotca...@adacore.com> wrote: >> More references to input_location aren't ideal. But I don't think >> that's a strong enough reason to reject. > >This can be avoided relatively easily though, patch to that effect >attached. > >Tested on x86-64/Linux, OK for the mainline?
But then why not expose this as extra field in ID instead of repeatedly calling gimple_location? I don't have an issue with using input_location here until we fix the gimplifier... Richard. > > * tree-inline.c (remap_gimple_stmt): Replace input_location with > gimple_location (id->call_stmt) throughout. > (copy_phis_for_bb): Likewise. > (expand_call_inline): Likewise. Tweak formatting.
