On Thu, Jun 28, 2018 at 8:58 AM, Janus Weil <ja...@gcc.gnu.org> wrote:
> But that still leaves us with a problem: The standard allows the > short-circuiting but it doesn't require it. Meaning that any other > compiler that does not do it (like ifort) is not in conflict with the > standard either. > > Many people may want to avoid such compiler-dependent behavior. That's > why we need a warning. All of the discussion here has shown that using > impure functions in logical expressions is not a good idea in Fortran. > It is not illegal, but it should be considered bad style. That's why > we need a warning: > > https://gcc.gnu.org/ml/fortran/2018-06/msg00160.html > > Does anyone agree with me that this is a useful diagnostic? Whether > this warning should be included in -Wall or -Wextra or -Whereever can > be debated. Is this patch ok for trunk? > Ok. (I think -Wsurprising is the correct place for this) -- Janne Blomqvist