On 06/13/2018 01:21 PM, Richard Biener wrote:
> On Fri, Jun 8, 2018 at 1:10 PM Martin Liška <mli...@suse.cz> wrote:
>>
>> Hi.
>>
>> Second follow-up patch uses flags_from_decl_or_type in LTO merging
>> of declarations. Hope it's more cleaner approach.
>>
>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>>
>> Ready to be installed?
>
> That doesn't handle the "error" attribute case anymore?
>
> We also have attribute_list_equal / attribute_list_contained that could be
> used here?
You are right, it can't work. Thus I would erase the FIXME comment.
Is it fine?
Martin
>
> Richard.
>
>> Martin
>From a9c0185ec343aa9064f5166645651e603a2b8538 Mon Sep 17 00:00:00 2001
From: marxin <mli...@suse.cz>
Date: Wed, 20 Jun 2018 10:01:48 +0200
Subject: [PATCH] Remove not longer valid FIXME comment.
gcc/lto/ChangeLog:
2018-06-20 Martin Liska <mli...@suse.cz>
* lto-symtab.c (lto_symtab_merge_p): Remove not valid
FIXME comment.
---
gcc/lto/lto-symtab.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/gcc/lto/lto-symtab.c b/gcc/lto/lto-symtab.c
index a40ba1f32ef..0d603c0281f 100644
--- a/gcc/lto/lto-symtab.c
+++ b/gcc/lto/lto-symtab.c
@@ -564,8 +564,6 @@ lto_symtab_merge_p (tree prevailing, tree decl)
}
}
- /* FIXME: after MPX is removed, use flags_from_decl_or_type
- function instead. PR lto/85248. */
if (DECL_ATTRIBUTES (prevailing) != DECL_ATTRIBUTES (decl))
{
tree prev_attr = lookup_attribute ("error", DECL_ATTRIBUTES (prevailing));
--
2.17.1
