Hi!
On Thu, Jun 07, 2018 at 04:10:08PM -0700, Carl Love wrote:
> The test files gcc/testsuite/gcc.target/powerpc/vsx-vector-
> 6[be|le].[p7|p8|p9].c cover testing for LE and BE for the various
> processors. These were setup before we had the le and be targets.
> Given that we now have the be and le targets the test files can be
> combined into a single file with the be and le qualifiers attached to
> the various instruction count checks. This reduces the number of files
> that need to be maintained.
>
> This patch removes the endian specific string in the test file name and
> combines the BE and LE versions for Power 8 into a single file.
Nice :-)
> 2018-06-07 Carl Love <c...@us.ibm.com>
>
> * gcc.target/powerpc/vsx-vector-6-be.p7.c: Rename vsx-vector-6.p7.c.
> * gcc.target/powerpc/vsx-vector-6-le.p9.c: Rename vsx-vector-6.p9.c.
> * gcc.target/powerpc/vsx-vector-6-be.p8.c: Delete file.
> * gcc.target/powerpc/vsx-vector-6-le.c: Rename vsx-vector-6.p8.c.
> Add le and be qualifiers for instruction counts.
> ---
> .../gcc.target/powerpc/vsx-vector-6-be.p7.c | 43 -----------------
> .../gcc.target/powerpc/vsx-vector-6-be.p8.c | 43 -----------------
> gcc/testsuite/gcc.target/powerpc/vsx-vector-6-le.c | 47 ------------------
> .../gcc.target/powerpc/vsx-vector-6-le.p9.c | 37 ---------------
> gcc/testsuite/gcc.target/powerpc/vsx-vector-6.p7.c | 50 ++++++++++++++++++++
> gcc/testsuite/gcc.target/powerpc/vsx-vector-6.p8.c | 55
> ++++++++++++++++++++++
> gcc/testsuite/gcc.target/powerpc/vsx-vector-6.p9.c | 39 +++++++++++++++
> 7 files changed, 144 insertions(+), 170 deletions(-)
The changelog does not match the diffstat. Ah, you do only mention the
new names in the description of the old names. Please do something like:
* gcc.target/powerpc/vsx-vector-6-be.p7.c: Rename to...
* gcc.target/powerpc/vsx-vector-6.p7.c: ... this.
* gcc.target/powerpc/vsx-vector-6-le.p9.c: Merge with...
* gcc.target/powerpc/vsx-vector-6-be.p8.c: ... this and rename to ...
* gcc.target/powerpc/vsx-vector-6.p9.c: ... this.
Well I totally messed that up but you get the idea :-)
Okay with a better changelog. Thanks!
Segher
