Segher:

> >     * gcc/config/rs6000/vsx.md (first_match_index_<mode>):
> >     Calculate index using natureal element order.
> 
> Typo ("natural").  You normally shouldn't do a line break after :
> btw.
> 

Fixed both issues.


> One thing that caught my eye, nothing new though:
> 
> >      {
> >        rtx tmp = gen_reg_rtx (SImode);
> > -      emit_insn (gen_vctzlsbb_<mode> (tmp, result));
> > +      if (!BYTES_BIG_ENDIAN)
> > +        emit_insn (gen_vctzlsbb_<mode> (tmp, result));
> > +      else
> > +        emit_insn (gen_vclzlsbb_<mode> (tmp, result));
> >        emit_insn (gen_ashrsi3 (operands[0], tmp, GEN_INT (sh)));
> >      }
> 
> Can this work with lshrsi3 instead?  That is slightly cheaper.
> 
> Looks great, please apply to trunk.  Thanks!

Yes, the builtin works with lshrsi3 change.  I will commit with this
change.

FYI, Bill would like to patch backported to GCC 8.  Is that OK?

                       Carl Love

Reply via email to