> That simplifies the patch, which now looks like this. Ok for trunk? > > paul > > gcc/ChangeLog: > > 2018-06-05 Paul Koning <n...@arrl.net> > > * compare-elim.c (try_merge_compare): Don't merge compare if > address contains a side effect. > * gcc.c-torture/compile/20180605-1.c: New test case.
The patch is OK, but its ChangeLog is not. :-) It does not modify one function but two (try_merge_compare and try_eliminate_compare). I would suggest using "diff -up" to generate patches with more context. -- Eric Botcazou
