On Wed, May 30, 2018 at 12:51 PM, Uros Bizjak <ubiz...@gmail.com> wrote: > On Wed, May 30, 2018 at 2:44 PM, Peryt, Sebastian > <sebastian.pe...@intel.com> wrote: >> Hi, >> >> I have made some cleaning to remove redundancy in includes call of some of >> the headers in x86intrin.h. >> Removed headers were included in both x86intrin.h and immintrin.h which is >> included into x86intrin.h. >> >> Is it ok for trunk? >> >> 2018-05-30 Sebastian Peryt <sebastian.pe...@intel.com> >> >> gcc/ >> >> * config/i386/cldemoteintrin.h: Change define from >> _X86INTRIN_H_INCLUDED >> to _IMMINTRIN_H_INCLUDED. >> * config/i386/pconfigintrin.h: Ditto. >> * config/i386/waitpkgintrin.h: Ditto. >> * config/i386/immintrin.h: Add includes for sgxintrin.h, >> pconfigintrin.h, waitpkgintrin.h and cldemoteintrin.h. >> * config/i386/x86intrin.h: Remove includes for mintrin.h, >> xmmintrin.h, >> emmintrin.h, pmmintrin.h, tmmintrin.h, smmintrin.h, wmmintrin.h, >> bmiintrin.h, bmi2intrin.h, lzcntintrin.h, sgxintrin.h, >> pconfigintrin.h, >> waitpkgintrin.h and cldemoteintrin.h. > > IIRC all new headers should be included through x86intrin.h. > > However, these headers follow ICC, so gcc should just copy what ICC > does. I'm not able to do any meaningful review in this area, lets ask > HJ for review and approval. >
Looks good to me. Thanks. -- H.J.
