> On 05/23/2018 09:54 AM, Jan Hubicka wrote: > >> On 05/08/2018 09:31 AM, Jan Hubicka wrote: > >>> Hi, > >>> this patch tells dwarf2out that it can have early debug not only in WPA > >>> mode > >>> but also when incrementally linking. This prevents ICE on almost every > >>> testcase > >>> compiled with -g. > >>> > >>> Bootstrapped/regtested x86_64-linux with rest of incremental linking > >>> patchet. > >>> Makes sense? > >>> > >>> Honza > >>> > >>> * dwarf2out.c (dwarf2out_die_ref_for_decl, > >>> darf2out_register_external_decl): Support incremental link. > >> OK. I think the full series is ACK'd now. Can you confirm? > > > > I hope so. I am not 100% sure if I need ACK from liberty maintainer for > > simple-object change. But since Richard is happy with it and he is the > > author > > of the code and gcc is the only user of this logic, I hope it is OK. > I think Richi's ACK for the libiberty bits is sufficient. > > > > > > As discussed with Richard on IRC, I still plan to update the driver to > > accept > > -fno-lto to imply codegen rather than requiring user to pass > > -flinker-output=nolto-rel > > which is somewhat odd, so I will send updated patch for that part. > Understood.
Actually I looked into it today and reminded why I did not do that at first place. -fno-lto is already supported and it disables the lto path - so the result is incremental link of all IL objects without merging the common sections (via linker) and is used by Andi's linux kernel patchset. I guess we want to keep this behaviour and thus I decided to go with the -flinker-output=nolto-rel. We can improve on it incrementally if we find better semantics. Honza > > jeff
