Hi!

Initializing the decomposition temporary from an expression with array type
is a special aggregate initialization path in which we wouldn't mark the
expression as read for the purposes of -Wunused-but-set*.

Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
trunk?

2018-05-29  Jakub Jelinek  <ja...@redhat.com>

        PR c++/85952
        * init.c (build_aggr_init): For structured binding initialized from
        array call mark_rvalue_use on the initializer.

        * g++.dg/warn/Wunused-var-33.C: New test.

--- gcc/cp/init.c.jj    2018-05-25 14:34:41.000000000 +0200
+++ gcc/cp/init.c       2018-05-28 19:04:10.504063972 +0200
@@ -1678,6 +1678,7 @@ build_aggr_init (tree exp, tree init, in
       if (VAR_P (exp) && DECL_DECOMPOSITION_P (exp))
        {
          from_array = 1;
+         init = mark_rvalue_use (init);
          if (init && DECL_P (init)
              && !(flags & LOOKUP_ONLYCONVERTING))
            {
--- gcc/testsuite/g++.dg/warn/Wunused-var-33.C.jj       2018-05-28 
19:32:00.236440573 +0200
+++ gcc/testsuite/g++.dg/warn/Wunused-var-33.C  2018-05-28 19:31:11.816372827 
+0200
@@ -0,0 +1,29 @@
+// PR c++/85952
+// { dg-do compile { target c++11 } }
+// { dg-options "-Wunused-but-set-variable" }
+
+int
+foo ()
+{
+  int a[2] = {1, 2};   // { dg-bogus "set but not used" } */
+  auto [x, y] = a;     // { dg-warning "structured bindings only available 
with" "" { target c++14_down } }
+  return x + y;
+}
+
+struct S { int d, e; };
+
+int
+bar ()
+{
+  S a = {1, 2};
+  auto [x, y] = a;     // { dg-warning "structured bindings only available 
with" "" { target c++14_down } }
+  return x + y;
+}
+
+int
+baz ()
+{
+  S a = {1, 2};
+  auto & [x, y] = a;   // { dg-warning "structured bindings only available 
with" "" { target c++14_down } }
+  return x + y;
+}

        Jakub

Reply via email to