On Mon, May 21, 2018 at 09:00:58AM +0200, Janus Weil wrote: > 2018-05-21 0:19 GMT+02:00 Steve Kargl <s...@troutmask.apl.washington.edu>: > > On Sun, May 20, 2018 at 09:44:47PM +0200, Janus Weil wrote: > >> > >> >> The patch still regtests cleanly. Ok for trunk? > >> > > >> > Patch looks good to me. The only thing that worries me is > >> > whether the patch will cause the SPEC benchmark to throw > >> > an error or warning that it did not before. As I don't have > >> > SPEC benchmark and it cost $$$, I'm not going to let it > >> > bother too much. > >> > >> Unfortunately I don't have access to SPEC either. Is anyone in a > >> position to check this? > > > > We'll find out evidently as one of the C/C++ developers run SPEC. > > Ok, we have plenty of time to fix up things before the next release anyway. >
Janus, The attached patch fixes a few testcases that were missed in the original patch. Do you have these already in an updated patch, or would you like me to commit my patch? -- Steve
Index: gcc/testsuite/gfortran.dg/graphite/block-2.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/block-2.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/block-2.f (working copy) @@ -1,3 +1,5 @@ +! { dg-do compile } +! { dg-options "-std=legacy" } SUBROUTINE MATRIX_MUL_UNROLLED (A, B, C, L, M, N) DIMENSION A(L,M), B(M,N), C(L,N) Index: gcc/testsuite/gfortran.dg/graphite/id-19.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/id-19.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/id-19.f (working copy) @@ -1,3 +1,5 @@ +! { dg-do compile } +! { dg-options "-std=legacy" } SUBROUTINE ECCODR(FPQR) DIMENSION FPQR(25,25,25) INTEGER P,Q,R Index: gcc/testsuite/gfortran.dg/graphite/id-20.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/id-20.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/id-20.f (working copy) @@ -1,4 +1,4 @@ -! { dg-options "-O3 -ffast-math" } +! { dg-options "-O3 -ffast-math -std=legacy" } DIMENSION FPQR(25,25,25) INTEGER P,Q,R Index: gcc/testsuite/gfortran.dg/graphite/id-27.f90 =================================================================== --- gcc/testsuite/gfortran.dg/graphite/id-27.f90 (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/id-27.f90 (working copy) @@ -1,4 +1,5 @@ -! { dg-additional-options "-Ofast" } +! { dg-do compile } +! { dg-additional-options "-Ofast -std=legacy" } MODULE module_ra_gfdleta INTEGER, PARAMETER :: NBLY=15 REAL , SAVE :: EM1(28,180),EM1WDE(28,180),TABLE1(28,180), & Index: gcc/testsuite/gfortran.dg/graphite/pr82449.f =================================================================== --- gcc/testsuite/gfortran.dg/graphite/pr82449.f (revision 260479) +++ gcc/testsuite/gfortran.dg/graphite/pr82449.f (working copy) @@ -1,5 +1,5 @@ ! { dg-do compile } -! { dg-options "-O2 -floop-nest-optimize" } +! { dg-options "-O2 -floop-nest-optimize -std=legacy" } SUBROUTINE JDFIDX(MKL,KGSH) DIMENSION MKL(6,6)