On 05/18/2018 02:49 AM, Prathamesh Kulkarni wrote: > Hi, > In r260250, the condition > > if (integer_zerop (retval)) > continue; > > was added before checking retval was of pointer type which caused > functions having return type apart from void *, to be marked as > malloc. The attached patch gets rid of the above check since we do not > wish to mark function returning NULL as malloc. > Also, it adds a check to return false if all args to phi are 0, > although I am not sure if this'd actually trigger in practice since > constant propagation should have folded the phi into constant 0 > already. > > Bootstrap+test in progress on x86_64-linux-gnu and aarch64-linux-gnu. > OK to commit if passes ? FWIW, I'm currently digging into a bootstrap failure on riscv64 that is triggered by the original change to allow functions returning NULL to potentially be malloc candidates. I'll give things a spin with this patch as well.
jeff