Hi!
On Fri, Apr 13, 2018 at 03:37:08PM -0500, Aaron Sawdey wrote:
> Per the discussion on the 83660, I've come to a minimal patch to
> prevent this. Basically marking the vec_extract tree as having side
> effects later makes sure that it gets all the cleanup points it needs
> so that gimplify_cleanup_point_expr () is happy. Also because
> vec_insert puts a MODIFY_EXPR in there, it has side effects and this
> problem will not occur.
>
> Doing bootstrap/regtest on ppc64le with -mcpu=power7 since that is
> where this issue arises. OK for trunk if everything passes?
> --- testsuite/gcc.target/powerpc/pr83660.C (nonexistent)
> +++ testsuite/gcc.target/powerpc/pr83660.C (working copy)
> @@ -0,0 +1,14 @@
> +/* PR target/83660 */
> +/* { dg-do compile } */
> +/* { dg-options "-mcpu=power7" } */
You'll need to skip this test if the user overrides -mcpu=; see the many
other testcases that do this.
With that fixed, okay for trunk. Thanks!
Segher
