On Thu, Apr 12, 2018 at 10:41:22AM +0200, Richard Biener wrote:
> On Thu, 12 Apr 2018, Jakub Jelinek wrote:
> > I'd like to ping the
> >
> > http://gcc.gnu.org/ml/gcc-patches/2018-03/msg01244.html
> > - PR83157 - improve debug info for x86 setcc peepholes
> >
> > patch. Thanks.
>
> OK for stage1 and backporting after it soaked there for a while.
> I'm too unfamiliar with the code to approve it at this point
> (esp. concerned about the cselib part affecting others than
> var-tracking in unexpected ways).
Thanks.
It shouldn't affect anything other than var-tracking,
as it is guarded with cselib_record_sets_hook != NULL and var-tracking is
the only cselib user that ever sets it to non-NULL (and clears afterwards).
Even if that would be left out, no other cselib user preserves cselib
VALUEs, so ! PRESERVED_VALUE_P (sets[n_sets + i].src_elt->val_rtx)
would be always true for non-var-tracking and the second loop wouldn't do
anything.
Jakub
