Hi Bill,

On Sun, Apr 01, 2018 at 08:24:32PM -0500, Bill Schmidt wrote:
>       * gcc.target/powerpc/undef-bool.C: New file.
>       * gcc.target/powerpc/undef-bool.c: New file.

I'm not sure two files with the same basename will not cause problems.
In either case it is confusing.  Please rename one?

> --- gcc/config/rs6000/xmmintrin.h     (revision 258958)
> +++ gcc/config/rs6000/xmmintrin.h     (working copy)
> @@ -58,6 +58,18 @@
>  #define _XMMINTRIN_H_INCLUDED
>  
>  #include <altivec.h>
> +
> +/* Avoid collisions between altivec.h and strict adherence to C++ and
> +   C11 standards.  This should eventually be done inside altivec.h itself,
> +   but only after testing a full distro build.  */
> +#if defined(__STRICT_ANSI__) && (defined(__cplusplus) || \
> +                              (defined(__STDC_VERSION__) &&  \
> +                               __STDC_VERSION__ >= 201112L))
> +#undef vector
> +#undef pixel
> +#undef bool
> +#endif

This won't work if anything made a macro for bool (etc.) before including
this header.  I guess we can live with that for now (it will not work
without your patch either).

Okay for trunk (with the testcase name fix).  Thanks!


Segher

Reply via email to