On Mon, Mar 26, 2018 at 11:05:52AM +0200, Tom de Vries wrote:
> OK for stage4 or stage1?

Ok for stage4, thanks.

Just a small nit below.

> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.c/switch-conversion-2.c
> @@ -0,0 +1,28 @@

No /* { dg-additional-options "-ftree-switch-conversion" } */
here, but:

> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.c/switch-conversion.c
> @@ -0,0 +1,35 @@
> +/* { dg-additional-options "-ftree-switch-conversion" } */

only here.  Either you don't need it at all, the default
flags are -O2 I think, or use it explicitly in all the testcases, not just 2
of them.  And, please add
/* PR tree-optimization/85063 */
as the first line of all those new testcases.

        Jakub

Reply via email to