>>>>> "Ed" == Ed Smith-Rowland <3dw...@verizon.net> writes:

Ed> +  /* Nonzero for the 2011 C++ Standard.  */
Ed> +  unsigned char cxx11;

I think it would be better if the new field name reflected its purpose,
so something like "user_literals".

Ed> +      if (ISIDST(*cur))
Ed> +   {
Ed> +     type = cpp_userdef_string_add_type (type);
Ed> +     ++cur;
Ed> +   }
Ed> +      while (ISIDNUM(*cur))

There are a few spots like this that are missing a space before an open
paren.

Otherwise the libcpp changes seem fine to me.  I don't actually know the
C++0x user-defined literal spec, though, so someone else will have to
review it for correctness against that.

Tom

Reply via email to