Hmm, actually I think any_erroneous_template_args will return false for error_mark_node. Just moving the error_mark_node check up should correct that. OK with that change.
On Fri, Mar 9, 2018 at 10:40 AM, Paolo Carlini <paolo.carl...@oracle.com> wrote: > Hi, > > On 09/03/2018 16:17, Jason Merrill wrote: >> >> You should be able to say >> >> if (any_erroneous_template_args (type)) > > Indeed, that's what I tried to express earlier today, after a cappuccino ;) >> >> and I don't think you need the goto; the normal logic should handle >> the truncated vecs fine. > > It should, otherwise something needs fixing anyway. And since by that time > we are in error recovery it doesn't make any sense to micro-optimize > anything. Thus, I'm re-testing (previous iteration was Ok) with the below. > Ok if it passes? > > Thanks, > Paolo. > > ///////////////////