RE: [patch][i386] Adding pconfig, wbnoinvd and wbinvd intrinsics

Fri, 02 Mar 2018 06:16:19 -0800 

Hi,

I have made changes to this patch.
I attached a new version.

02.03.2018  Olga Makhotina  <olga.makhot...@intel.com>

gcc/
        * common/config/i386/i386-common.c (OPTION_MASK_ISA_PCONFIG_SET,
        OPTION_MASK_ISA_PCONFIG_UNSET, OPTION_MASK_ISA_WBNOINVD_SET,
        OPTION_MASK_ISA_WBNOINVD_UNSET): New definitions.
        (ix86_handle_option): Handle -mpconfig and -mwbnoinvd.
        * config.gcc (pconfigintrin.h, wbnoinvdintrin.h) : Add headers.
        * config/i386/cpuid.h (bit_PCONFIG, bit_WBNOINVD): New.
        * config/i386/driver-i386.c (host_detect_local_cpu): Detect -mpconfig
        and -mwbnoinvd.
        * config/i386/i386-builtin.def (__builtin_ia32_wbnoinvd,
        __builtin_ia32_wbinvd): New builtins.
        (SPECIAL_ARGS2): New.
        * config/i386/i386-c.c (__WBNOINVD__, __PCONFIG__): New.
        (SPECIAL_ARGS2): New.
        * config/i386/i386.c (ix86_target_string): Add -mpconfig and -mwbnoinvd.
        (ix86_valid_target_attribute_inner_p): Ditto.
        (ix86_init_mmx_sse_builtins): Add special_args2.
        * config/i386/i386.h (TARGET_PCONFIG, TARGET_PCONFIG_P, TARGET_WBNOINVD,
        TARGET_WBNOINVD_P): New.
        * config/i386/i386.md (UNSPECV_WBINVD, UNSPECV_WBNOINVD): New.
        (define_insn "wbinvd", define_insn "wbnoinvd"): New.
        * config/i386/i386.opt: Add -mpconfig and -mwbnoinvd.
        * config/i386/immintrin.h (_wbinvd): New intrinsic.
        * config/i386/pconfigintrin.h: New file.
        * config/i386/wbnoinvdintrin.h: Ditto.
        * config/i386/x86intrin.h: Add headers pconfigintrin.h and 
wbnoinvdintrin.h.
        * doc/invoke.texi (-mpconfig, -mwbnoinvd): New.

gcc/testsuite/
        * g++.dg/other/i386-2.C: Add -mpconfig and -mwbnoinvd.
        * g++.dg/other/i386-3.C: Ditto.
        * gcc.target/i386/sse-12.c: Ditto.
        * gcc.target/i386/sse-13.c: Ditto.
        * gcc.target/i386/sse-14.c: Ditto.
        * gcc.target/i386/sse-23.c: Add pconfig and wbnoinvd.
        * gcc.target/i386/wbinvd-1.c: New test.
        * gcc.target/i386/wbnoinvd-1.c: Ditto.
        * gcc.target/i386/pconfig-1.c: Ditto.   

Is it ok for trunk?

Thanks, Olga.

-----Original Message-----
From: Uros Bizjak [mailto:ubiz...@gmail.com] 
Sent: Tuesday, February 6, 2018 10:51 AM
To: gcc-patches@gcc.gnu.org
Cc: Makhotina, Olga <olga.makhot...@intel.com>; Kirill Yukhin 
<kirill.yuk...@gmail.com>
Subject: Re: [patch][i386] Adding pconfig, wbnoinvd and wbinvd intrinsics

> This patch adds new intrinsics: pconfig, wbnoinvd and wbinvd.
>
> 05.02.2018  Olga Makhotina  <olga.makhot...@intel.com>
>
> gcc/
> * common/config/i386/i386-common.c (OPTION_MASK_ISA_PCONFIG_SET, 
> OPTION_MASK_ISA_PCONFIG_UNSET, OPTION_MASK_ISA_WBNOINVD_SET,
> OPTION_MASK_ISA_WBNOINVD_UNSET): New definitions.
> (ix86_handle_option): Handle -mpconfig and -mwbnoinvd.
> * config.gcc (pconfigintrin.h, wbnoinvdintrin.h) : Add headers.
> * config/i386/cpuid.h (bit_PCONFIG, bit_WBNOINVD): New.
> * config/i386/driver-i386.c (host_detect_local_cpu): Detect -mpconfig 
> and -mwbnoinvd.
> * config/i386/i386-builtin.def (__builtin_ia32_wbnoinvd,
> __builtin_ia32_wbinvd): New builtins.
> (SPECIAL_ARGS2): New.
> * config/i386/i386-c.c (__WBNOINVD__, __PCONFIG__): New.
> (SPECIAL_ARGS2): New.
> * config/i386/i386.c (ix86_target_string): Add -mpconfig and -mwbnoinvd.
> (ix86_valid_target_attribute_inner_p): Ditto.
> (ix86_init_mmx_sse_builtins): Add special_args2.
> * config/i386/i386.h (TARGET_PCONFIG, TARGET_PCONFIG_P, 
> TARGET_WBNOINVD,
> TARGET_WBNOINVD_P): New.
> * config/i386/i386.md (UNSPECV_WBINVD, UNSPECV_WBNOINVD): New.
> (define_insn "wbinvd", define_insn "wbnoinvd"): New.
> * config/i386/i386.opt: Add -mpconfig and -mwbnoinvd.
> * config/i386/immintrin.h (_wbinvd): New intrinsic.
> * config/i386/sgxintrin.h (_enclv_u32): Ditto.
> * config/i386/pconfigintrin.h: New file.
> * config/i386/wbnoinvdintrin.h: Ditto.
> * config/i386/x86intrin.h: Add headers pconfigintrin.h and wbnoinvdintrin.h.
> * doc/invoke.texi (-mpconfig, -mwbnoinvd): New.
>
> gcc/testsuite/
> * g++.dg/other/i386-2.C: Add -mpconfig and -mwbnoinvd.
> * g++.dg/other/i386-3.C: Ditto.
> * gcc.target/i386/sse-12.c: Ditto.
> * gcc.target/i386/sse-13.c: Ditto.
> * gcc.target/i386/sse-14.c: Ditto.
> * gcc.target/i386/sgx.c (_enclv_u32): New tests.
> * gcc.target/i386/sse-23.c: Add pconfig and wbnoinvd.
> * gcc.target/i386/wbinvd-1.c: New test.
> * gcc.target/i386/wbnoinvd-1.c: Ditto.
> * gcc.target/i386/pconfig-1.c: Ditto.
>
> Is it ok for trunk?

Please split out SGX changes to a separate patch.

OK for mainline with the above change.

Thanks,
Uros.

Attachment: 0001-wbnoinvd_pconfig.patch
Description: 0001-wbnoinvd_pconfig.patch

Reply via email to