Hi!
On Mon, Feb 12, 2018 at 03:35:27PM -0600, Will Schmidt wrote:
> Noticed during review of test results. I expect the intent
> here was to compile in cases where the run command was not
> valid.
> But for the scan-assembler stanza to work, need to have compile results
> in all cases.
> --- a/gcc/testsuite/gcc.target/powerpc/altivec-consts.c
> +++ b/gcc/testsuite/gcc.target/powerpc/altivec-consts.c
> @@ -1,7 +1,11 @@
> +/* altivec-consts.c:
> + Requires vmx_hw support to run. Requires altivec support to compile.
> + This test varies from le-altivec-consts.c in the ordering of the
> + vector elements below. */
> /* { dg-do run { target { powerpc*-*-* && vmx_hw } } } */
> -/* { dg-do compile { target { powerpc*-*-* && { ! vmx_hw } } } } */
> +/* { dg-do compile { target { powerpc*-*-* } } } */
> /* { dg-require-effective-target powerpc_altivec_ok } */
> /* { dg-options "-maltivec -mabi=altivec -O2" } */
As dg.exp (in dejagnu itself) says:
# Multiple instances are supported (since we don't support target and xfail
# selectors on one line), though it doesn't make much sense to change the
# compile/assemble/link/run field. Nor does it make any sense to have
# multiple lines of target selectors (use one line).
You can just leave out the "dg-do compile" line and it will still run the
compile tests if the "dg-do run"'s target selector does not match (and
btw., you can remove the powerpc*-*-* part of the selectors, this is
always true in gcc.target/powerpc/).
Same for the other test. Okay with that chance (if that works :-) )
Thanks!
Segher
