Hi DJ,

>>Looks OK to me, but wait a day or two for a docs person to comment on...
6 days no comments so far, can I check in now?

>>if the new line is too long
There are many other lines which have the same length or are even longer
this is why I let it as it is.

Also based on comments from Jakub (on a different patch) I corrected the
Changelog entry for this patch (see below). Is this OK?

Best Regards,
Sebastian

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 257588)
+++ ChangeLog   (working copy)
@@ -1,3 +1,13 @@
+2018-02-12  Sebastian Perta  <sebastian.pe...@renesas.com>
+
+       * config/rl78/rl78.c (add_vector_labels): New function.
+       * config/rl78/rl78.c (rl78_handle_vector_attribute): New function.
+       * config/rl78/rl78.c (rl78_start_function): Call add_vector_labels.
+       * config/rl78/rl78.c (rl78_handle_func_attribute): Removed the
assert 
+       which checks that no arguments are passed.
+       * config/rl78/rl78.c (rl78_attribute_table): Add "vector" attribute.
+       * doc/extend.texi: Documentation for the new attribute.
+
 2018-02-12  Richard Biener  <rguent...@suse.de>
 
        PR tree-optimization/84037
Index: testsuite/ChangeLog
===================================================================
--- testsuite/ChangeLog (revision 257588)
+++ testsuite/ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2018-02-12  Sebastian Perta  <sebastian.pe...@renesas.com>
+
+       * gcc.target/rl78/test_auto_vector.c: New test.
+
 2018-02-12  Tamar Christina  <tamar.christ...@arm.com>
 
        PR target/82641



> -----Original Message-----
> From: DJ Delorie [mailto:d...@redhat.com]
> Sent: 06 February 2018 22:57
> To: Sebastian Perta <sebastian.pe...@renesas.com>
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] RL78 new "vector" function attribute
> 
> 
> Sebastian Perta <sebastian.pe...@renesas.com> writes:
> > I've updated the patch (extend.texi) as you suggested.
> > Please let me know if this is OK to check-in, thank you!
> 
> Looks OK to me, but wait a day or two for a docs person to comment on...
> 
> > -On RX targets, you may specify one or more vector numbers as arguments
> > +On RX and RL78 targets, you may specify one or more vector numbers as
> arguments
> 
> ...if the new line is too long and if a paragraph reformat is warranted.
> 
> Thanks!

Reply via email to