The testcase seems to be failing on configurations where the default thumb version differs from the one it's setting it to, Causing a warning on TARGET_ARM_ARCH_ISA_THUMB.
I will submit a patch soon to undefine all relevant built-ins using builtin_define_with_int_value before setting them again. Thanks, Tamar > -----Original Message----- > From: Kyrill Tkachov [mailto:kyrylo.tkac...@foss.arm.com] > Sent: Tuesday, February 6, 2018 10:38 > To: Tamar Christina <tamar.christ...@arm.com>; gcc-patches@gcc.gnu.org > Cc: nd <n...@arm.com>; Ramana Radhakrishnan > <ramana.radhakrish...@arm.com>; Richard Earnshaw > <richard.earns...@arm.com>; ni...@redhat.com > Subject: Re: [PATCH][GCC][ARM] Silence ARM_ARCH redefinition warning > and keep better track of architecturs already emitted. > > > On 05/02/18 11:52, Tamar Christina wrote: > > Hi All, > > > > This patch silences the warnings that were emitted when certain ACLE > > macros were being redefined when using the new target pragma or > attribute to change architecture level. > > > > It also keeps better track of which arch directives have already been > > emitted. This allows special cases that existed before to keep working as > they did before. > > > > Regtested on arm-none-eabi and no regressions. > > Bootstrapped and regtested on arm-none-Linux-gnueabihf and no issues. > > > > Ok for trunk and backport to the GCC-8 branch? > > > > Thanks Tamar, this is in line with what we do for aarch64 as well. > Ok for trunk. > There is no GCC 8 branch, and this is GCC 8 functionality so this shouldn't > need to be backported anywhere. > > Kyrill > > > Thanks, > > Tamar > > > > > > gcc/ > > 2018-02-05 Tamar Christina <tamar.christ...@arm.com> > > > > PR target/82641 > > * config/arm/arm.c (arm_print_asm_arch_directives): Record already > > emitted arch directives. > > * config/arm/arm-c.c (arm_cpu_builtins): Undefine __ARM_ARCH and > > __ARM_FEATURE_COPROC before changing architectures. > > > > gcc/testsuite > > 2018-02-05 Tamar Christina <tamar.christ...@arm.com> > > > > PR target/82641 > > * gcc.target/arm/pragma_arch_switch_2.c: New. > > > > --
