On Sat, Jan 27, 2018 at 1:31 AM, Steve Kargl <s...@troutmask.apl.washington.edu> wrote: > The attached patch implements a check for F2015:C830. > The wording of the F2008:C531 is nearly identical, but > the restriction on BLOCK is noted in the normative test. > The 3 lines in the new testcase show be sufficient to > see the issue. In regression testing, I needed to > adjust the regex pattern in a few existing test because > it seems my patch now catches the problem earlier. > > Regression tested on x86_64-*-freebsd. OK to commit?
+ /* F2015:C830 (R816) An explicit-shape-spec whose bounds are not This should be F2018:C830 (The wording of that constraint has not changed). The year of the standard has been changed to reflect the year when it's (expected to be) published. See the latest draft (N2146 at the time of writing this) at https://wg5-fortran.org/ . Otherwise the patch is Ok. However, given that this is apparently something which has never worked and is thus not a regression, and we're in stage4(?), you might want to get approval from the release manager. IMHO, given that the patch itself is fairly simple and fixes an ICE, I support committing it for gcc-8. -- Janne Blomqvist
