On Wed, Oct 19, 2011 at 08:40:07AM +0200, Andi Kleen wrote:
> diff --git a/gcc/ggc-page.c b/gcc/ggc-page.c
> index 2da99db..ba88e3f 100644
> --- a/gcc/ggc-page.c
> +++ b/gcc/ggc-page.c
> @@ -736,6 +736,7 @@ alloc_page (unsigned order)
> entry_size = num_objects * OBJECT_SIZE (order);
> if (entry_size < G.pagesize)
> entry_size = G.pagesize;
> + entry_size = ROUND_UP (entry_size, G.pagesize);
Isn't the "if (entry_size < G.pagesize) entry_size = G.pagesize;"
above this now redundant? I'm fairly sure we never call this with
zero num_objects or zero OBJECT_SIZE (order) and for anything
else ROUND_UP should round < pagesize to pagesize, right?
Jakub
