On Mon, Jan 22, 2018 at 6:14 PM, Jakub Jelinek <ja...@redhat.com> wrote: > On Mon, Jan 22, 2018 at 04:49:34PM -0500, Jason Merrill wrote: >> On Thu, Jan 18, 2018 at 6:13 PM, Jakub Jelinek <ja...@redhat.com> wrote: >> > Before location wrappers were introduced, the >> > potential_constant_expression_1 >> > assumption that a VIEW_CONVERT_EXPR must have non-NULL type was right, >> > if it is a type dependent reinterpret cast, it would be >> > REINTERPRET_CAST_EXPR instead. >> > >> > Location wrappers around decls can have NULL type, if the decl they wrap >> > also has NULL type. >> >> Hmm, why would a decl have NULL type? Are we wrapping a CONST_DECL in >> VIEW_CONVERT_EXPR? They should get NON_LVALUE_EXPR, since they aren't >> lvalues (except the objc++ ones that have TREE_STATIC set). > > So, do you want following instead, if it passes bootstrap/regtest?
Looks good. Jason