On Sat, 13 Jan 2018, Boris Kolpackov wrote: > Joseph Myers <jos...@codesourcery.com> writes: > > > Contrary to a previous review, you should *not* be removing RejectNegative > > from -fdebug-prefix-map=, and should be including it on both the new > > options. [...] > > > > The patch is OK with that fixed. > > Thanks for finding the time to review this on the last minute. Below is > the new revision of the patch. The changes compared to the previous > revision are: > > 1. Rebase to the latest trunk. > > 2. Add RejectNegative back for -fdebug-prefix-map as well as for the two > new options. > > 3. Use strrchr() instead of strchr() when looking for '=' in the option > value. This change is suggested here[1] and the reasoning is that we > (as project authors) can control paths inside our projects (not to > have any '=') but not where the users choose to build them. > > While strictly speaking this is a backwards-incompatible change, the > old semantics in the presence of '=' is a broken build, so this is > probably ok (but if not, let me know and I will revert this change). > > I've also added this rationale to add_prefix_map() and a note in the > ChangeLog.
This version is OK. -- Joseph S. Myers jos...@codesourcery.com
