Hi Julian,
There are a couple of minor formatting nits. >+static int >+arm_movmemqi_unaligned (rtx *operands) .... >+ /* Inlined memcpy using ldr/str/ldrh/strh can be quite big: try to limit >+ size of code if optimizing for size. We'll use ldm/stm if >src_aligned >+ or dst_aligned though: allow more interleaving in those cases since the >+ resulting code can be smaller. */ Watch out the or being misaligned compared to the other text. >+ /* Note that the loop created by arm_block_move_unaligned_loop may be >+ subject to loop unrolling, which makes tuning this condition a little >+ redundant. */ Same with `redundant' On 13 October 2011 18:53, Julian Brown <jul...@codesourcery.com> wrote: > On Wed, 28 Sep 2011 14:33:17 +0100 > No, sorry, I don't have any benchmark results available at present. I > think we'd have to have terrifically bad luck for it to be a > performance degradation, though... Hmmm OK - but please watch out for any bug reports or any test-suite fallout this week with multilibs other than what you might have tested. > > I re-tested the patch for good measure, in case of bitrot (and the new > tests pass with the patch applied, of course). OK to apply now? OK by me with those changes. cheers Ramana
