On 01/02/2018 09:02 PM, Jeff Law wrote:
* config/i386/i386.c (ix86_adjut_stack_and_probe_stack_clash): Do not
Typo: “adjut”.
explicitly probe *sp in a noreturn function if there were any callee
register saves.
I recompiled glibc with this patch, and I can confirm it fixes the new
glibc test:
https://sourceware.org/ml/libc-alpha/2017-12/msg00987.html
However, I would appreciate if it were possible to avoid emitting the
.cfi_offset/.cfi_register annotations and only record the change of
frame address. The other CFI notes aren't needed, and it would avoid
reintroducing this bug if the way the prologue is constructed changes
and the condition for emitting the probe is not completely correct anymore.
Thanks,
Florian
