On Thu, Dec 14, 2017 at 02:40:12PM +0100, Tom de Vries wrote: > --- a/gcc/testsuite/gcc.dg/visibility-22.c > +++ b/gcc/testsuite/gcc.dg/visibility-22.c > @@ -1,6 +1,7 @@ > /* PR target/32219 */ > /* { dg-do run } */ > /* { dg-require-visibility "" } */ > +/* { dg-require-effective-target weak_undefined } */ > /* { dg-options "-O2 -fPIC" { target fpic } } */ > /* This test requires support for undefined weak symbols. This support > is not available on hppa*-*-hpux*. The test is skipped rather than
Shouldn't then the: /* This test requires support for undefined weak symbols. This support is not available on hppa*-*-hpux*. The test is skipped rather than xfailed to suppress the warning that would otherwise arise. */ /* { dg-skip-if "" { "hppa*-*-hpux*" "*-*-aix*" "*-*-darwin*" } } */ stuff be dropped too? Jakub