Hi All, Please consider this patch abandoned. I have submitted a new version.
Thanks, Tamar > -----Original Message----- > From: Christophe Lyon [mailto:christophe.l...@linaro.org] > Sent: Monday, December 11, 2017 12:11 > To: Tamar Christina <tamar.christ...@arm.com> > Cc: gcc-patches@gcc.gnu.org; nd <n...@arm.com>; Ramana Radhakrishnan > <ramana.radhakrish...@arm.com>; Richard Earnshaw > <richard.earns...@arm.com>; ni...@redhat.com; Kyrylo Tkachov > <kyrylo.tkac...@arm.com> > Subject: Re: [PATCH][GCC][ARM] Fix failing testcase pragma_fpu_attribute.c > > On 11 December 2017 at 12:56, Tamar Christina <tamar.christ...@arm.com> > wrote: > >> > > > >> > > It also works when I build natively using just configure && make. > >> > > Could be > >> > something in the configure flags. > >> > > Looking back at it, if the vanilla compiler doesn't support neon > >> > > I can see the test failing. But fixing it means Turning on neon > >> > > and then turning it > >> > off after the include. Which makes the test do too many things. > >> > > >> > What are your configure flags? > >> > Can you can&paste the command line used to compile the testcase > >> > (from > >> > gcc.log) ? > >> > > > > Ah, Richard pointed out to me that the difference is in "soft" abi, I > > was only testing Softfp and hard. I'll write a new testcase that should work > for all. > > > > Indeed, you override the float-abi flags in your RUNTESTFLAGS, which I'm not > doing. > > I think your arm-none-eabi builds have soft, softfp and hard multilibs? > > With arm-none-linux-gnueabi[hf], you cannot override float-abi as easily, see > for instance: > https://gcc.gnu.org/ml/gcc-patches/2017-11/msg02323.html > > Thanks, > > Christophe > > > Thanks > > > >> They are: > >> > >> Schedule of variations: > >> arm-eabi-aem/-marm/-march=armv7-a/-mfpu=vfpv3-d16/-mfloat- > >> abi=softfp > >> arm-eabi-aem/-mthumb/-march=armv8-a/-mfpu=crypto-neon-fp- > armv8/- > >> mfloat-abi=hard > >> > >> > >> /build-arm-none-eabi/obj/gcc2/gcc/xgcc -B/build-arm-none- > >> eabi/obj/gcc2/gcc/ > >> /src/gcc/gcc/testsuite/gcc.target/arm/pragma_fpu_attribute_2.c -marm > >> - march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp > >> -fno-diagnostics-show- caret -fdiagnostics-color=never -ansi > >> -pedantic-errors -std=gnu99 -ffat-lto- objects -S > >> -specs=aprofile-validation.specs -Wa,-mno-warn-deprecated -o > >> pragma_fpu_attribute_2.s > >> > >> /build-arm-none-eabi/obj/gcc2/gcc/xgcc -B/build-arm-none- > >> eabi/obj/gcc2/gcc/ > >> /src/gcc/gcc/testsuite/gcc.target/arm/pragma_fpu_attribute.c -marm - > >> march=armv7-a -mfpu=vfpv3-d16 -mfloat-abi=softfp > >> -fno-diagnostics-show- caret -fdiagnostics-color=never -ansi > >> -pedantic-errors -std=gnu99 -ffat-lto- objects -S > >> -specs=aprofile-validation.specs -Wa,-mno-warn-deprecated -o > >> pragma_fpu_attribute.s > >> > >> /build-arm-none-eabi/obj/gcc2/gcc/xgcc -B/build-arm-none- > >> eabi/obj/gcc2/gcc/ > >> /src/gcc/gcc/testsuite/gcc.target/arm/pragma_fpu_attribute_2.c - > mthumb - > >> march=armv8-a -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -fno- > >> diagnostics-show-caret -fdiagnostics-color=never -ansi > >> -pedantic-errors - > >> std=gnu99 -ffat-lto-objects -S -specs=aprofile-validation.specs -Wa,-mno- > >> warn-deprecated -o pragma_fpu_attribute_2.s > >> > >> /build-arm-none-eabi/obj/gcc2/gcc/xgcc -B/build-arm-none- > >> eabi/obj/gcc2/gcc/ > >> /src/gcc/gcc/testsuite/gcc.target/arm/pragma_fpu_attribute.c -mthumb > >> - march=armv8-a -mfpu=crypto-neon-fp-armv8 -mfloat-abi=hard -fno- > >> diagnostics-show-caret -fdiagnostics-color=never -ansi > >> -pedantic-errors - > >> std=gnu99 -ffat-lto-objects -S -specs=aprofile-validation.specs > >> -Wa,-mno- warn-deprecated -o pragma_fpu_attribute.s > >> > >> It's also weird that you only see one of the testcases failing. > >> The pragma_fpu_attribute.c and pragma_fpu_attribute_2.c should have > >> the exact same issues. > >> > >> > > >> > Thanks > >> > > >> > > > >> > > I will try to think of a testcase that doesn't require neon, if > >> > > I can't I'll just > >> > remove the tests. > >> > > They weren't being tested before and if there's no way to > >> > > reliably test changing fpu options on ARM Then there's no point > having them. > >> > > > >> > > >> > Yes, that's becoming way too complex for the purpose :( > >> > >> I think I can do one using the fmla instructions. So will try that next. > >> > >> > > >> > > Thanks, > >> > > Tamar > >> > > > >> > >> > >> > >> Christophe
