On Wed, Nov 22, 2017 at 8:16 PM, Thomas Koenig <tkoe...@netcologne.de> wrote: > Hi janne, > >> Regtested on x86_64-pc-linux-gnu, Ok for trunk? > > > Jerry already OK'd this, so you can commit if you want. > What you could do is to hide the macro invocation behind > a macro in libgfortran.h, something like > > #define BIG_ENDIAN (__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__) > > Also, I have opened PR libfortran/83097 for this, you > can mention this in the ChangeLog entry. > > Regards > > Thomas
Hi, in light of Andreas comments, and also since the meaning of the old big_endian variable was apparently confusing enough that somebody had deemed it necessary to explain it in multiple places where it was used, I committed the original patch as r255072. Having the conditional explicitly where it's used at least makes it pretty clear what we're testing. Also thanks for opening a PR, I mentioned this in the ChangeLog and commit msg. -- Janne Blomqvist
