On Wed, Nov 22, 2017 at 10:09:08AM +0000, Richard Sandiford wrote:
> This patch replaces the REDUC_*_EXPR tree codes with internal functions.
> This is needed so that the support for in-order reductions can also use
> internal functions without too much complication.
>
> This came out of the review for:
> https://gcc.gnu.org/ml/gcc-patches/2017-11/msg01516.html
>
> Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu.
> OK to install?
Wouldn't it be better to just have IFN_REDUC that takes as an additional
argument INTEGER_CST with tree_code of the operation (so REDUC_MAX_EXPR
would be transformed into REDUC (MAX_EXPR, ...) etc.)?
That way we wouldn't need to add further internal fns if we want say
multiplication reduction, or some other.
Jakub
