Igor
> -----Original Message-----
> From: H.J. Lu [mailto:[email protected]]
> Sent: Wednesday, November 8, 2017 7:18 PM
> To: Tsimbalist, Igor V <[email protected]>
> Cc: Jeff Law <[email protected]>; [email protected];
> [email protected]
> Subject: Re: [PATCH 21/22] Add extra field to gtm_jmpbuf on x86 only
>
> On Tue, Nov 7, 2017 at 8:22 AM, Tsimbalist, Igor V
> <[email protected]> wrote:
> > I decided to split my previous patch "Enable building libitm with Intel CET
> > "
> > into two different patches. The first patch will add a new field to sjlj.S
> > and
> > target.h files. The second one will add Intel CET support on the top of the
> > first one. In this case the further changes for adding Intel CET support are
> > seen clearly.
> >
> > Ok for trunk?
> >
>
> libitm/configure.tgt should check ${target} like the other places:
>
> +# Update libtool_VERSION since the size of struct gtm_jmpbuf is
> +# changed for x86.
> +case "${host}" in
>
> Did these come from cut and paste?
>
> + # For x86, we use slots in the TCB head for most of our TLS.
> + # The setup of those slots in beginTransaction can afford to
> + # use the global-dynamic model.
>
> I think the whole thing should be:
>
> case "${target}" in
> # Update libtool_VERSION since the size of struct gtm_jmpbuf is
> # changed for x86.
> i[456]86-*-* | x86_64-*-*)
> libtool_VERSION=2:0:0
> ;;
> esac
There was a feedback from Joseph (email attached) with the comment about
similar case in cet.m4:
> This file is checking $target. That's only ever appropriate in
directories
> building compilers and similar tools; target library directories
should check
> $host, as the host for target libraries is the target for the
compiler.
Igor
>
>
>
> --
> H.J.
--- Begin Message ---
> -----Original Message-----
> From: Joseph Myers [mailto:[email protected]]
> Sent: Thursday, October 12, 2017 10:36 PM
> To: Tsimbalist, Igor V <[email protected]>
> Cc: [email protected]; Jeff Law <[email protected]>; [email protected]
> Subject: Re: [PATCH 07/22] Enable building libgcc with CET options.
>
> On Thu, 12 Oct 2017, Tsimbalist, Igor V wrote:
>
> > Enable building libgcc with CET options by default on Linux/x86 if
> > binutils supports CET v2.0.
> > It can be disabled with --disable-cet. It is an error to configure
> > GCC with --enable-cet if bintuiils doesn't support CET v2.0.
> >
> > config/
> > * cet.m4: New file
>
> This file is checking $target. That's only ever appropriate in directories
> building compilers and similar tools; target library directories should check
> $host, as the host for target libraries is the target for the compiler.
Fixed.
> This file has a comment
>
> > +dnl GCC_CET_LIBRARY
> > +dnl (SHELL-CODE_HANDLER)
>
> which doesn't seem to match the subsequent definition of GCC_CET_FLAGS.
Fixed.
> I don't see any documentation of the new configure option. I'd expect the
> first patch adding such an option to document it in install.texi, and then
> subsequent patches to update that documentation if those patches extend
> the option to cover more things.
Added the description of this configure option to install.texi.
The updated patch is attached.
Igor
> --
> Joseph S. Myers
> [email protected]
0007-Enable-building-libgcc-with-CET-options.patch
Description: 0007-Enable-building-libgcc-with-CET-options.patch
--- End Message ---
