On Mon, 30 Oct 2017, Michael Meissner wrote:

> This patch fixes exporting the non __builtin_ names to be done by default only
> for the C language.  I added a target hook in case a port needs to enable
> built-ins for C++ (either wholesale, or for particular built-in functions).

Testing lang_GNU_C () can't possibly be correct here; ObjC should always 
be handled like C unless there is a strong reason not to do so, explicitly 
commented.

Also, I'd expect the FALLBACK_P argument to DEF_BUILTIN to be true, not a 
call to the hook; __builtin_sqrtf128 should always end up generating a 
call to the out-of-line sqrtf128 function if not inlined, regardless of 
source language.

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to