On October 25, 2017 2:27:12 AM GMT+02:00, Alan Modra <amo...@gmail.com> wrote: >On Tue, Oct 24, 2017 at 11:48:27AM +0200, Richard Biener wrote: >> On Tue, 24 Oct 2017, Alan Modra wrote: >> > The problem with making discarded symbols hidden is that the >> > non-default visibility is sticky. When symbols other than the >> > __gnu_lto ones are discarded that turns out to be a bad idea. >> >> So a UNDEF weak hidden causes a later non-weak defined default >> visibility symbol to become hidden? The wonders of ELF ... > >Yes.. > >> > Bootstrapped and regression tested powerpc64le-linux. OK? >> >> Ok. > >Committed r254042. Let's hope this works. Rewriting the symbol >table, which of course is the right thing to do rather than these >hacks, is a pain. Relocations would need r_info updates, and so would >group signatures.
Yeah. There's a reason why I didn't do that... Richard.