On Fri, Oct 06, 2017 at 01:45:15PM +0100, Tamar Christina wrote:
> Hi All,
> 
> this is a respin with the changes suggested. Note that this patch is no 8/8 
> in the series.
> 
> Regtested on arm-none-eabi, armeb-none-eabi,
> aarch64-none-elf and aarch64_be-none-elf with no issues found.
> 
> Ok for trunk?
> 
> gcc/testsuite
> 2017-10-06  Tamar Christina  <tamar.christ...@arm.com>
> 
>         * gcc.dg/vect/vect-reduc-dot-s8a.c
>         (dg-additional-options, dg-require-effective-target): Add +dotprod.
>         * gcc.dg/vect/vect-reduc-dot-u8a.c
>         (dg-additional-options, dg-require-effective-target): Add +dotprod.

> diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-s8a.c 
> b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-s8a.c
> index 
> dc4f52019d5435edbbc811b73dee0f98ff44c1b1..acb6862f8274fb954f69bd45e8edeedcdca4cbf7
>  100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-s8a.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-s8a.c
> @@ -1,4 +1,7 @@
>  /* { dg-require-effective-target vect_int } */
> +/* { dg-require-effective-target arm_v8_2a_dotprod_neon_hw { target { 
> aarch64*-*-* || arm*-*-* } } } */
> +/* { dg-additional-options "-O3 -march=armv8.2-a+dotprod" { target { 
> aarch64*-*-* || arm*-*-* } } } */

Drop the -O3, should this one only apply for AArch64?

> +/* { dg-add-options arm_v8_2a_dotprod_neon }  */
>  
>  #include <stdarg.h>
>  #include "tree-vect.h"
> diff --git a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-u8a.c 
> b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-u8a.c
> index 
> f3cc6c78c25305d91becd585be8949514ebc521c..c23fe5df252b94d6722708096b8aba7edd100f1a
>  100644
> --- a/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-u8a.c
> +++ b/gcc/testsuite/gcc.dg/vect/vect-reduc-dot-u8a.c
> @@ -1,4 +1,7 @@
>  /* { dg-require-effective-target vect_int } */
> +/* { dg-require-effective-target arm_v8_2a_dotprod_neon_hw { target { 
> aarch64*-*-* || arm*-*-* } } } */
> +/* { dg-additional-options "-O3 -march=armv8.2-a+dotprod" { target { 
> aarch64*-*-* || arm*-*-* } } } */

Drop the -O3, should this one only apply for AArch64?

Likewise here.

Otherwise, this is OK for trunk.

Reviewed By: <james.greenha...@arm.com>

Thanks,
James

Reply via email to