On Fri, Oct 06, 2017 at 09:52:35AM +0000, Sudi Das wrote:
> This patch is a fix for PR 82440.
> The predicates aarch64_reg_or_bic_imm and aarch64_reg_or_orr_imm missed out on
> checking for a CONST_VECTOR before calling aarch64_simd_valid_immediate
> function.
> Also I think James forgot to add the test cases in the original patch
> submitted.
>
> Testing done : Checked for regressions on bootstrapped aarch64-none-linux-gnu.
> Ok for trunk?
>
> Thanks
> Sudi
>
> The ChangeLog entry is as follows:
>
> *** gcc/ChangeLog ***
>
> 2017-10-06 Sudakshina Das <sudi....@arm.com>
>
> PR target/82440
> * config/aarch64/predicates.md (aarch64_reg_or_orr_imm): Modified.
> (aarch64_reg_or_bic_imm): Likewise.
I'll defer the actual review to aarch64 maintainers, just want to say that
this is not a correct ChangeLog entry. You should say what has changed, not
just that something has changed. Something like
Only call aarch64_simd_valid_immediate on CONST_VECTORs.
or similar.
Jakub
