On Fri, 2017-09-29 at 11:15 -0400, David Malcolm wrote: > On Sun, 2017-09-17 at 20:00 -0400, Eric Gallager wrote: > > Attached is a version of > > https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00481.html that > > contains > > a combination of both the fix and the testcase update, as requested > > in > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81794#c2 > > > > I had to use a different computer than I usually use to send this > > email, as the hard drive that originally had this patch is > > currently > > unresponsive. Since it's also the one with my ssh keys on it, I > > can't > > commit with it. Sorry if the ChangeLogs get mangled. > > Thanks for putting this together; sorry about the delay in reviewing > it. > > The patch mostly looks good. > > Did you perform a full bootstrap and run of the testsuite with this > patch? If so, it's best to state this in the email, so that we know > that the patch has survived this level of testing. > > Some nits below: > > > libcpp/ChangeLog: > > > > 2017-03-24 Eric Gallager <eg...@gwmail.gwu.edu> > > > > * macro.c (check_trad_stringification): Have warning be > > controlled by > > -Wtraditional. > > > > gcc/testsuite/ChangeLog: > > > > 2017-09-17 Eric Gallager <eg...@gwmail.gwu.edu> > > > > PR preprocessor/81794 > > * gcc.dg/pragma-diag-7.c: Update to include check for > > stringification.
Another nit: both ChangeLog entries ought to have the "PR preprocessor/81794" heading (currently only the testsuite one does).
