On 09/11/2017 03:59 PM, Max Filippov wrote: > Hi Richard, > > On Mon, Sep 11, 2017 at 2:36 PM, Richard Sandiford > <richard.sandif...@linaro.org> wrote: >> Max Filippov <jcmvb...@gmail.com> writes: >>> 2017-09-11 Max Filippov <jcmvb...@gmail.com> >>> gcc/ >>> * expmed.c (emit_store_flag_int): Initialize rtx tem. >> >> LGTM, thanks, but I can't approve it. >> >> This makes the later "tem = 0;" redundant, so perhaps it would make >> sense to delete that too? There again, it was redundant before the >> split as well. >> >> An alternative would be to only test tem when we've done something >> with it, as below, but I don't know if that's better or a step backwards. > > this works for me too, so whichever fix you like better. I like narrowing the scope better -- it's a lot easier to reason about the code when the def and uses are close and there's not a ton of control flow.
Jeff
