On Wed, Sep 06, 2017 at 06:26:10PM +0200, Jakub Jelinek wrote: > > Maybe this "switch to the other section" thing should be abstracted out? > > Messing with in_cold_section_p is a bit dirty. > > But it reflects the reality, and is what final.c and varasm.c also do.
Yes, but those aren't target code :-) I'm suggesting adding a generic switch_from_hot_to_cold_or_the_other_way_around function (but with a better name ;-) ) that just does these same two lines, only not in target code. Seems cleaner to me, less surprising. But, okay either way. Segher