On 06/23/2017 11:19 AM, Renlin Li wrote:
+__attribute__ ((used))
+void
+my_memmove (void *d, const void *s, size_t n)
+{
+ char *dst = (char *) d;
+ const char *src = (const char *) s;
+ if (src >= dst)
+ while (n--)
+ *dst++ = *src++;
+ else
+ {
+ dst += n;
+ src += n;
+ while (n--)
+ *--dst = *--src;
+ }
+}
+
The memops-asm.c testcase fails for nvptx because of a mismatch between
function definition and function declaration for my_memmove in the
generated nvptx code.
man memmove show us that memmove returns a 'void *', not 'void':
...
void *memmove(void *dest, const void *src, size_t n);
...
and that it returns its first argument (well, the formulation could be
improved):
...
RETURN VALUE
The memmove() function returns a pointer to dest.
...
Fixed in attached patch.
Committed.
Thanks,
- Tom
Fix my_memmove in gcc.c-torture/execute/builtins/memops-asm-lib.c
2017-08-06 Tom de Vries <t...@codesourcery.com>
* gcc.c-torture/execute/builtins/memops-asm-lib.c (my_memmove): Fix return
type. Add missing return.
---
gcc/testsuite/gcc.c-torture/execute/builtins/memops-asm-lib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/gcc/testsuite/gcc.c-torture/execute/builtins/memops-asm-lib.c b/gcc/testsuite/gcc.c-torture/execute/builtins/memops-asm-lib.c
index 25d4a40..3baf7a6 100644
--- a/gcc/testsuite/gcc.c-torture/execute/builtins/memops-asm-lib.c
+++ b/gcc/testsuite/gcc.c-torture/execute/builtins/memops-asm-lib.c
@@ -38,7 +38,7 @@ my_bcopy (const void *s, void *d, size_t n)
}
__attribute__ ((used))
-void
+void *
my_memmove (void *d, const void *s, size_t n)
{
char *dst = (char *) d;
@@ -53,6 +53,8 @@ my_memmove (void *d, const void *s, size_t n)
while (n--)
*--dst = *--src;
}
+
+ return d;
}
/* LTO code is at the present to able to track that asm alias my_bcopy on builtin
